Remove raw DictionaryValue::Set in //components

components/sync/engine_impl/js_sync_encryption_handler_observer_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/engine_impl/js_sync_encryption_handler_observer.h"
 
+#include <utility>
+
 #include "base/location.h"
+#include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/test/scoped_task_environment.h"
 #include "base/values.h"
 #include "components/sync/base/cryptographer.h"
 #include "components/sync/base/fake_encryptor.h"
 #include "components/sync/base/model_type.h"
 #include "components/sync/base/passphrase_type.h"
 #include "components/sync/base/time.h"
 #include "components/sync/engine/sync_string_conversions.h"
 #include "components/sync/js/js_event_details.h"
@@ skipping 79 matching lines @@
   EXPECT_CALL(mock_js_event_handler_,
               HandleJsEvent("onBootstrapTokenUpdated",
                             HasDetailsAsDictionary(bootstrap_token_details)));
 
   js_sync_encryption_handler_observer_.OnBootstrapTokenUpdated(
       "sensitive_token", PASSPHRASE_BOOTSTRAP_TOKEN);
   PumpLoop();
 }
 
 TEST_F(JsSyncEncryptionHandlerObserverTest, OnEncryptedTypesChanged) {
-  base::DictionaryValue expected_details;
-  base::ListValue* encrypted_type_values = new base::ListValue();
-  const bool encrypt_everything = false;
-  expected_details.Set("encryptedTypes", encrypted_type_values);
-  expected_details.SetBoolean("encryptEverything", encrypt_everything);
+  auto encrypted_type_values = base::MakeUnique<base::ListValue>();
   ModelTypeSet encrypted_types;
 
   for (int i = FIRST_REAL_MODEL_TYPE; i < MODEL_TYPE_COUNT; ++i) {
     ModelType type = ModelTypeFromInt(i);
     encrypted_types.Put(type);
     encrypted_type_values->AppendString(ModelTypeToString(type));
   }
 
+  base::DictionaryValue expected_details;
+  const bool encrypt_everything = false;

[vabr (Chromium), 2017/06/01 19:53:33]

optional nit: Should this actually be kEncryptEverything?

[jdoerrie, 2017/06/02 09:39:56]

Done.

+  expected_details.Set("encryptedTypes", std::move(encrypted_type_values));
+  expected_details.SetBoolean("encryptEverything", encrypt_everything);
+
   EXPECT_CALL(mock_js_event_handler_,
               HandleJsEvent("onEncryptedTypesChanged",
                             HasDetailsAsDictionary(expected_details)));
 
   js_sync_encryption_handler_observer_.OnEncryptedTypesChanged(
       encrypted_types, encrypt_everything);
   PumpLoop();
 }
 
 TEST_F(JsSyncEncryptionHandlerObserverTest, OnCryptographerStateChanged) {
@@ skipping 27 matching lines @@
               HandleJsEvent("onPassphraseTypeChanged",
                             HasDetailsAsDictionary(passphrase_type_details)));
 
   js_sync_encryption_handler_observer_.OnPassphraseTypeChanged(
       PassphraseType::IMPLICIT_PASSPHRASE, ProtoTimeToTime(10));
   PumpLoop();
 }
 
 }  // namespace
 }  // namespace syncer