components/sync/base/model_type.h - Issue 2889163002: Remove raw DictionaryValue::Set in //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/base/model_type.h

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)

Patch Set: Nits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/base/model_type.h

diff --git a/components/sync/base/model_type.h b/components/sync/base/model_type.h

index eb8365323f7beb9a8e4f57afde54870ea2e6b010..1d84ceda90400bc1d740c8949501b3a3c45a9ba7 100644

--- a/components/sync/base/model_type.h

+++ b/components/sync/base/model_type.h

@@ -285,9 +285,7 @@ const char* ModelTypeToString(ModelType model_type);

int ModelTypeToHistogramInt(ModelType model_type);

// Handles all model types, and not just real ones.

-//

-// Caller takes ownership of returned value.

-base::Value* ModelTypeToValue(ModelType model_type);

+std::unique_ptr<base::Value> ModelTypeToValue(ModelType model_type);

// Converts a Value into a ModelType - complement to ModelTypeToValue().

ModelType ModelTypeFromValue(const base::Value& value);