components/sync/syncable/syncable_id_unittest.cc - Issue 2889163002: Remove raw DictionaryValue::Set in //components

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/sync/syncable/syncable_id_unittest.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)

Patch Set: Nits Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/sync/syncable/syncable_id.cc ('k') | components/sync/syncable/write_transaction_info.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/sync/syncable/syncable_id.h"	5 #include "components/sync/syncable/syncable_id.h"

6	6

7 #include <vector>	7 #include <vector>

8	8

9 #include "base/test/values_test_util.h"	9 #include "base/test/values_test_util.h"

10 #include "base/values.h"	10 #include "base/values.h"

(...skipping 65 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
76 ASSERT_GT(j->GetLexicographicSuccessor(), *i);	76 ASSERT_GT(j->GetLexicographicSuccessor(), *i);

77 ASSERT_GT(j->GetLexicographicSuccessor(),	77 ASSERT_GT(j->GetLexicographicSuccessor(),

78 i->GetLexicographicSuccessor());	78 i->GetLexicographicSuccessor());

79 ASSERT_GT(*j, i->GetLexicographicSuccessor());	79 ASSERT_GT(*j, i->GetLexicographicSuccessor());

80 }	80 }

81 }	81 }

82 }	82 }

83 }	83 }

84	84

85 TEST(SyncableIdTest, ToValue) {	85 TEST(SyncableIdTest, ToValue) {

86 base::ExpectStringValue("r", Id::CreateFromServerId("0").ToValue());	86 base::ExpectStringValue("r", *Id::CreateFromServerId("0").ToValue());

87 base::ExpectStringValue("svalue", Id::CreateFromServerId("value").ToValue());	87 base::ExpectStringValue("svalue", *Id::CreateFromServerId("value").ToValue());

88	88

89 base::ExpectStringValue("r", Id::CreateFromClientString("0").ToValue());	89 base::ExpectStringValue("r", *Id::CreateFromClientString("0").ToValue());

90 base::ExpectStringValue("cvalue",	90 base::ExpectStringValue("cvalue",

91 Id::CreateFromClientString("value").ToValue());	91 *Id::CreateFromClientString("value").ToValue());

92 }	92 }

93	93

94 } // namespace syncable	94 } // namespace syncable

95 } // namespace syncer	95 } // namespace syncer

OLD	NEW