Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: components/policy/core/common/config_dir_policy_loader_unittest.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/config_dir_policy_loader_unittest.cc
diff --git a/components/policy/core/common/config_dir_policy_loader_unittest.cc b/components/policy/core/common/config_dir_policy_loader_unittest.cc
index 640eb37eb1583744cf7cb7efff3e6064c6db24d7..5e1db90049a4ca123ee83939ccbcc310f90f4c96 100644
--- a/components/policy/core/common/config_dir_policy_loader_unittest.cc
+++ b/components/policy/core/common/config_dir_policy_loader_unittest.cc
@@ -11,6 +11,7 @@
#include "base/files/scoped_temp_dir.h"
#include "base/json/json_string_value_serializer.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/sequenced_task_runner.h"
#include "base/strings/string_number_conversions.h"
@@ -121,7 +122,7 @@ void TestHarness::InstallBooleanPolicy(const std::string& policy_name,
void TestHarness::InstallStringListPolicy(const std::string& policy_name,
const base::ListValue* policy_value) {
base::DictionaryValue dict;
- dict.Set(policy_name, policy_value->DeepCopy());
+ dict.Set(policy_name, base::MakeUnique<base::Value>(*policy_value));
WriteConfigFile(dict, NextConfigFileName());
}
@@ -129,13 +130,13 @@ void TestHarness::InstallDictionaryPolicy(
const std::string& policy_name,
const base::DictionaryValue* policy_value) {
base::DictionaryValue dict;
- dict.Set(policy_name, policy_value->DeepCopy());
+ dict.Set(policy_name, base::MakeUnique<base::Value>(*policy_value));
WriteConfigFile(dict, NextConfigFileName());
}
void TestHarness::Install3rdPartyPolicy(const base::DictionaryValue* policies) {
base::DictionaryValue dict;
- dict.Set("3rdparty", policies->DeepCopy());
+ dict.Set("3rdparty", base::MakeUnique<base::Value>(*policies));
WriteConfigFile(dict, NextConfigFileName());
}

Powered by Google App Engine
This is Rietveld 408576698