components/printing/test/print_web_view_helper_browsertest.cc - Issue 2889163002: Remove raw DictionaryValue::Set in //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/test/print_web_view_helper_browsertest.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)

Patch Set: Nits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/printing/test/print_web_view_helper_browsertest.cc

diff --git a/components/printing/test/print_web_view_helper_browsertest.cc b/components/printing/test/print_web_view_helper_browsertest.cc

index 3c708f782108dc32617401b50847f0e8b7218437..8f4e244aad64033088440ae465cb1d3781fcc4c0 100644

--- a/components/printing/test/print_web_view_helper_browsertest.cc

+++ b/components/printing/test/print_web_view_helper_browsertest.cc

@@ -1054,7 +1054,7 @@ TEST_F(MAYBE_PrintWebViewHelperPreviewTest, OnPrintForPrintPreviewWithScaling) {

// Non default scaling value

dict.SetInteger(kSettingScaleFactor, 80);

- dict.Set(kSettingMediaSize, media_size.release());

+ dict.Set(kSettingMediaSize, std::move(media_size));

OnPrintForPrintPreview(dict);