Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: components/sync/syncable/syncable_id_unittest.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/syncable/syncable_id.cc ('k') | components/sync/syncable/write_transaction_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/syncable/syncable_id_unittest.cc
diff --git a/components/sync/syncable/syncable_id_unittest.cc b/components/sync/syncable/syncable_id_unittest.cc
index c537db51dbff7b79a575ac6ac853a22111150e48..c29167405e41298445fa72210279cfb19a33dc52 100644
--- a/components/sync/syncable/syncable_id_unittest.cc
+++ b/components/sync/syncable/syncable_id_unittest.cc
@@ -83,12 +83,12 @@ TEST(SyncableIdTest, GetLeastIdForLexicographicComparison) {
}
TEST(SyncableIdTest, ToValue) {
- base::ExpectStringValue("r", Id::CreateFromServerId("0").ToValue());
- base::ExpectStringValue("svalue", Id::CreateFromServerId("value").ToValue());
+ base::ExpectStringValue("r", *Id::CreateFromServerId("0").ToValue());
+ base::ExpectStringValue("svalue", *Id::CreateFromServerId("value").ToValue());
- base::ExpectStringValue("r", Id::CreateFromClientString("0").ToValue());
+ base::ExpectStringValue("r", *Id::CreateFromClientString("0").ToValue());
base::ExpectStringValue("cvalue",
- Id::CreateFromClientString("value").ToValue());
+ *Id::CreateFromClientString("value").ToValue());
}
} // namespace syncable
« no previous file with comments | « components/sync/syncable/syncable_id.cc ('k') | components/sync/syncable/write_transaction_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698