Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: components/sync/js/js_event_details_unittest.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync/js/js_event_details.h" 5 #include "components/sync/js/js_event_details.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility>
8 9
10 #include "base/memory/ptr_util.h"
11 #include "base/values.h"
9 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
10 13
11 namespace syncer { 14 namespace syncer {
12 namespace { 15 namespace {
13 16
14 class JsEventDetailsTest : public testing::Test {}; 17 class JsEventDetailsTest : public testing::Test {};
15 18
16 TEST_F(JsEventDetailsTest, EmptyList) { 19 TEST_F(JsEventDetailsTest, EmptyList) {
17 JsEventDetails details; 20 JsEventDetails details;
18 EXPECT_TRUE(details.Get().empty()); 21 EXPECT_TRUE(details.Get().empty());
19 EXPECT_EQ("{}", details.ToString()); 22 EXPECT_EQ("{}", details.ToString());
20 } 23 }
21 24
22 TEST_F(JsEventDetailsTest, FromDictionary) { 25 TEST_F(JsEventDetailsTest, FromDictionary) {
23 base::DictionaryValue dict; 26 base::DictionaryValue dict;
24 dict.SetString("foo", "bar"); 27 dict.SetString("foo", "bar");
25 dict.Set("baz", new base::ListValue()); 28 dict.Set("baz", base::MakeUnique<base::ListValue>());
26 29
27 std::unique_ptr<base::DictionaryValue> dict_copy(dict.DeepCopy()); 30 auto dict_copy = base::MakeUnique<base::DictionaryValue>(dict);
28 31
29 JsEventDetails details(&dict); 32 JsEventDetails details(&dict);
30 33
31 // |details| should take over |dict|'s data. 34 // |details| should take over |dict|'s data.
32 EXPECT_TRUE(dict.empty()); 35 EXPECT_TRUE(dict.empty());
33 EXPECT_TRUE(details.Get().Equals(dict_copy.get())); 36 EXPECT_TRUE(details.Get().Equals(dict_copy.get()));
34 } 37 }
35 38
36 } // namespace 39 } // namespace
37 } // namespace syncer 40 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698