Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: components/sync/syncable/model_type_unittest.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/syncable/model_type.cc ('k') | components/sync/syncable/syncable_id.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/syncable/model_type_unittest.cc
diff --git a/components/sync/syncable/model_type_unittest.cc b/components/sync/syncable/model_type_unittest.cc
index 701f4d3e19c19ae7376055970a370dfb78802cc1..f2a6bb91b355de9b9eafb0d2f6bfc569a34f4a88 100644
--- a/components/sync/syncable/model_type_unittest.cc
+++ b/components/sync/syncable/model_type_unittest.cc
@@ -21,11 +21,11 @@ TEST_F(ModelTypeTest, ModelTypeToValue) {
for (int i = FIRST_REAL_MODEL_TYPE; i < MODEL_TYPE_COUNT; ++i) {
ModelType model_type = ModelTypeFromInt(i);
base::ExpectStringValue(ModelTypeToString(model_type),
- ModelTypeToValue(model_type));
+ *ModelTypeToValue(model_type));
}
base::ExpectStringValue("Top-level folder",
- ModelTypeToValue(TOP_LEVEL_FOLDER));
- base::ExpectStringValue("Unspecified", ModelTypeToValue(UNSPECIFIED));
+ *ModelTypeToValue(TOP_LEVEL_FOLDER));
+ base::ExpectStringValue("Unspecified", *ModelTypeToValue(UNSPECIFIED));
}
TEST_F(ModelTypeTest, ModelTypeFromValue) {
« no previous file with comments | « components/sync/syncable/model_type.cc ('k') | components/sync/syncable/syncable_id.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698