Remove raw DictionaryValue::Set in //components

components/webcrypto/algorithms/hmac_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 
+#include <utility>
+
 #include "base/logging.h"
+#include "base/memory/ptr_util.h"
 #include "base/values.h"
 #include "components/webcrypto/algorithm_dispatch.h"
 #include "components/webcrypto/algorithms/test_helpers.h"
 #include "components/webcrypto/crypto_data.h"
 #include "components/webcrypto/status.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebCryptoAlgorithmParams.h"
 #include "third_party/WebKit/public/platform/WebCryptoKeyAlgorithm.h"
 
 namespace webcrypto {
@@ skipping 201 matching lines @@
                       CreateHmacImportAlgorithmNoLength(
                           blink::kWebCryptoAlgorithmIdSha1),
                       true, 0, &key));
 }
 
 TEST_F(WebCryptoHmacTest, ImportKeyJwkKeyOpsSignVerify) {
   blink::WebCryptoKey key;
   base::DictionaryValue dict;
   dict.SetString("kty", "oct");
   dict.SetString("k", "GADWrMRHwQfoNaXU5fZvTg");
-  base::ListValue* key_ops = new base::ListValue;
-  dict.Set("key_ops", key_ops);  // Takes ownership.
+  base::ListValue* key_ops =
+      dict.SetList("key_ops", base::MakeUnique<base::ListValue>());
 
   key_ops->AppendString("sign");
 
   EXPECT_EQ(Status::Success(),
             ImportKeyJwkFromDict(dict,
                                  CreateHmacImportAlgorithmNoLength(
                                      blink::kWebCryptoAlgorithmIdSha256),
                                  false, blink::kWebCryptoKeyUsageSign, &key));
 
   EXPECT_EQ(blink::kWebCryptoKeyUsageSign, key.Usages());
 
   key_ops->AppendString("verify");
 
   EXPECT_EQ(Status::Success(),
             ImportKeyJwkFromDict(dict,
                                  CreateHmacImportAlgorithmNoLength(
                                      blink::kWebCryptoAlgorithmIdSha256),
                                  false, blink::kWebCryptoKeyUsageVerify, &key));
 
   EXPECT_EQ(blink::kWebCryptoKeyUsageVerify, key.Usages());
 }
 
 // Test 'use' inconsistent with 'key_ops'.
 TEST_F(WebCryptoHmacTest, ImportKeyJwkUseInconsisteWithKeyOps) {
   blink::WebCryptoKey key;
   base::DictionaryValue dict;
   dict.SetString("kty", "oct");
   dict.SetString("k", "GADWrMRHwQfoNaXU5fZvTg");
-  base::ListValue* key_ops = new base::ListValue;
-  dict.Set("key_ops", key_ops);  // Takes ownership.
-
   dict.SetString("alg", "HS256");
   dict.SetString("use", "sig");
+
+  auto key_ops = base::MakeUnique<base::ListValue>();
   key_ops->AppendString("sign");
   key_ops->AppendString("verify");
   key_ops->AppendString("encrypt");
+  dict.Set("key_ops", std::move(key_ops));
   EXPECT_EQ(
       Status::ErrorJwkUseAndKeyopsInconsistent(),
       ImportKeyJwkFromDict(
           dict,
           CreateHmacImportAlgorithmNoLength(blink::kWebCryptoAlgorithmIdSha256),
           false,
           blink::kWebCryptoKeyUsageSign | blink::kWebCryptoKeyUsageVerify,
           &key));
 }
 
@@ skipping 325 matching lines @@
   // On export the last 4 bits has been set to zero.
   std::vector<uint8_t> raw_key;
   EXPECT_EQ(Status::Success(),
             ExportKey(blink::kWebCryptoKeyFormatRaw, key, &raw_key));
   EXPECT_BYTES_EQ(HexStringToBytes("b1f0"), raw_key);
 }
 
 }  // namespace
 
 }  // namespace webcrypto