Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Unified Diff: components/sync/test/fake_server/fake_server.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/syncable/write_transaction_info.cc ('k') | components/sync_wifi/wifi_credential.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/test/fake_server/fake_server.cc
diff --git a/components/sync/test/fake_server/fake_server.cc b/components/sync/test/fake_server/fake_server.cc
index c2a1a603e51de1d4cc45dbddb49fc835e41f5943..de1cb209907ecd8ea7256b7e968a9d785c977fc4 100644
--- a/components/sync/test/fake_server/fake_server.cc
+++ b/components/sync/test/fake_server/fake_server.cc
@@ -504,7 +504,8 @@ FakeServer::GetEntitiesAsDictionaryValue() {
// Initialize an empty ListValue for all ModelTypes.
ModelTypeSet all_types = ModelTypeSet::All();
for (ModelTypeSet::Iterator it = all_types.First(); it.Good(); it.Inc()) {
- dictionary->Set(ModelTypeToString(it.Get()), new base::ListValue());
+ dictionary->Set(ModelTypeToString(it.Get()),
+ base::MakeUnique<base::ListValue>());
}
for (EntityMap::const_iterator it = entities_.begin(); it != entities_.end();
« no previous file with comments | « components/sync/syncable/write_transaction_info.cc ('k') | components/sync_wifi/wifi_credential.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698