Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: components/sync/syncable/base_node.h

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sync/protocol/sync_protocol_error.cc ('k') | components/sync/syncable/base_node.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SYNC_SYNCABLE_BASE_NODE_H_ 5 #ifndef COMPONENTS_SYNC_SYNCABLE_BASE_NODE_H_
6 #define COMPONENTS_SYNC_SYNCABLE_BASE_NODE_H_ 6 #define COMPONENTS_SYNC_SYNCABLE_BASE_NODE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 164
165 // Returns this item's position within its parent. 165 // Returns this item's position within its parent.
166 // Do not call this function on items that do not support positioning 166 // Do not call this function on items that do not support positioning
167 // (ie. non-bookmarks). 167 // (ie. non-bookmarks).
168 int GetPositionIndex() const; 168 int GetPositionIndex() const;
169 169
170 // Returns this item's attachment ids. 170 // Returns this item's attachment ids.
171 const AttachmentIdList GetAttachmentIds() const; 171 const AttachmentIdList GetAttachmentIds() const;
172 172
173 // Returns a base::DictionaryValue serialization of this node. 173 // Returns a base::DictionaryValue serialization of this node.
174 base::DictionaryValue* ToValue() const; 174 std::unique_ptr<base::DictionaryValue> ToValue() const;
175 175
176 protected: 176 protected:
177 BaseNode(); 177 BaseNode();
178 virtual ~BaseNode(); 178 virtual ~BaseNode();
179 179
180 // These virtual accessors provide access to data members of derived classes. 180 // These virtual accessors provide access to data members of derived classes.
181 virtual const syncable::Entry* GetEntry() const = 0; 181 virtual const syncable::Entry* GetEntry() const = 0;
182 virtual const BaseTransaction* GetTransaction() const = 0; 182 virtual const BaseTransaction* GetTransaction() const = 0;
183 183
184 // Determines whether part of the entry is encrypted, and if so attempts to 184 // Determines whether part of the entry is encrypted, and if so attempts to
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 227
228 // Same as |unencrypted_data_|, but for legacy password encryption. 228 // Same as |unencrypted_data_|, but for legacy password encryption.
229 std::unique_ptr<sync_pb::PasswordSpecificsData> password_data_; 229 std::unique_ptr<sync_pb::PasswordSpecificsData> password_data_;
230 230
231 DISALLOW_COPY_AND_ASSIGN(BaseNode); 231 DISALLOW_COPY_AND_ASSIGN(BaseNode);
232 }; 232 };
233 233
234 } // namespace syncer 234 } // namespace syncer
235 235
236 #endif // COMPONENTS_SYNC_SYNCABLE_BASE_NODE_H_ 236 #endif // COMPONENTS_SYNC_SYNCABLE_BASE_NODE_H_
OLDNEW
« no previous file with comments | « components/sync/protocol/sync_protocol_error.cc ('k') | components/sync/syncable/base_node.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698