Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: components/cloud_devices/common/printer_description.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cloud_devices/common/printer_description.cc
diff --git a/components/cloud_devices/common/printer_description.cc b/components/cloud_devices/common/printer_description.cc
index aa7fa38d51703e856414027737298b3f82dbc37b..3cff18981a91e1b3fbac5e076837efa4ff756a3b 100644
--- a/components/cloud_devices/common/printer_description.cc
+++ b/components/cloud_devices/common/printer_description.cc
@@ -13,6 +13,7 @@
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/string_util.h"
#include "base/values.h"
#include "components/cloud_devices/common/cloud_device_description_consts.h"
@@ -733,16 +734,15 @@ class PageRangeTraits : public ItemsTraits<kOptionPageRange> {
static void Save(const PageRange& option, base::DictionaryValue* dict) {
if (!option.empty()) {
- base::ListValue* list = new base::ListValue;
- dict->Set(kPageRangeInterval, list);
+ auto list = base::MakeUnique<base::ListValue>();
for (size_t i = 0; i < option.size(); ++i) {
- std::unique_ptr<base::DictionaryValue> interval(
- new base::DictionaryValue);
+ auto interval = base::MakeUnique<base::DictionaryValue>();
interval->SetInteger(kPageRangeStart, option[i].start);
if (option[i].end < kMaxPageNumber)
interval->SetInteger(kPageRangeEnd, option[i].end);
list->Append(std::move(interval));
}
+ dict->Set(kPageRangeInterval, std::move(list));
}
}
};

Powered by Google App Engine
This is Rietveld 408576698