Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: components/search_engines/default_search_policy_handler.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/default_search_policy_handler.cc
diff --git a/components/search_engines/default_search_policy_handler.cc b/components/search_engines/default_search_policy_handler.cc
index 83a356515b00bdc82fe9f39c88feaeba71801ba0..295334d2d0f37a44c6172d724e203f15730e06a8 100644
--- a/components/search_engines/default_search_policy_handler.cc
+++ b/components/search_engines/default_search_policy_handler.cc
@@ -36,7 +36,8 @@ void SetListInPref(const PolicyMap& policies,
bool is_list = policy_value->GetAsList(&policy_list);
DCHECK(is_list);
}
- dict->Set(key, policy_list ? policy_list->DeepCopy() : new base::ListValue());
+ dict->Set(key, policy_list ? base::MakeUnique<base::ListValue>(*policy_list)
+ : base::MakeUnique<base::ListValue>());
}
// Extracts a string from a policy value and adds it to a pref dictionary.

Powered by Google App Engine
This is Rietveld 408576698