components/invalidation/impl/p2p_invalidator.cc - Issue 2889163002: Remove raw DictionaryValue::Set in //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/impl/p2p_invalidator.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)

Patch Set: Nits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/invalidation/impl/p2p_invalidator.cc

diff --git a/components/invalidation/impl/p2p_invalidator.cc b/components/invalidation/impl/p2p_invalidator.cc

index 92562ab8b8be704d61e8cf35b853943d6f056576..0502815e70cda4335a8ba625b996a288c5490c57 100644

--- a/components/invalidation/impl/p2p_invalidator.cc

+++ b/components/invalidation/impl/p2p_invalidator.cc

@@ -106,7 +106,7 @@ std::string P2PNotificationData::ToString() const {

base::DictionaryValue dict;

dict.SetString(kSenderIdKey, sender_id_);

dict.SetString(kNotificationTypeKey, P2PNotificationTargetToString(target_));

- dict.Set(kInvalidationsKey, invalidation_map_.ToValue().release());

+ dict.Set(kInvalidationsKey, invalidation_map_.ToValue());

std::string json;

base::JSONWriter::Write(dict, &json);

return json;