Remove raw DictionaryValue::Set in //components

components/sync/base/model_type.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SYNC_BASE_MODEL_TYPE_H_
 #define COMPONENTS_SYNC_BASE_MODEL_TYPE_H_
 
 #include <map>
 #include <memory>
 #include <ostream>
@@ skipping 267 matching lines @@
 // Returns a pointer to a string with application lifetime that represents
 // the name of |model_type|.
 const char* ModelTypeToString(ModelType model_type);
 
 // Some histograms take an integer parameter that represents a model type.
 // The mapping from ModelType to integer is defined here.  It should match
 // the mapping from integer to labels defined in histograms.xml.
 int ModelTypeToHistogramInt(ModelType model_type);
 
 // Handles all model types, and not just real ones.
 //

[vabr (Chromium), 2017/06/01 19:53:33]

nit: The empty comment line seems unnecessary. It was presumably a separator for
the removed line about ownership.

[jdoerrie, 2017/06/02 09:39:56]

Done.

-// Caller takes ownership of returned value.
-base::Value* ModelTypeToValue(ModelType model_type);
+std::unique_ptr<base::Value> ModelTypeToValue(ModelType model_type);
 
 // Converts a Value into a ModelType - complement to ModelTypeToValue().
 ModelType ModelTypeFromValue(const base::Value& value);
 
 // Returns the ModelType corresponding to the name |model_type_string|.
 ModelType ModelTypeFromString(const std::string& model_type_string);
 
 // Returns the comma-separated string representation of |model_types|.
 std::string ModelTypeSetToString(ModelTypeSet model_types);
 
@@ skipping 50 matching lines @@
 
 // Returns true if |model_type| supports parent-child hierarchy or entries.
 bool TypeSupportsHierarchy(ModelType model_type);
 
 // Returns true if |model_type| supports ordering of sibling entries.
 bool TypeSupportsOrdering(ModelType model_type);
 
 }  // namespace syncer
 
 #endif  // COMPONENTS_SYNC_BASE_MODEL_TYPE_H_