Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: components/sync/protocol/sync_protocol_error.h

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/js/js_event_details_unittest.cc ('k') | components/sync/protocol/sync_protocol_error.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/protocol/sync_protocol_error.h
diff --git a/components/sync/protocol/sync_protocol_error.h b/components/sync/protocol/sync_protocol_error.h
index cfb1edfc29ecb29aa069b945c525669a195af965..c76efb1c9c3c5792f6f99dc31f3872304ba2bfc4 100644
--- a/components/sync/protocol/sync_protocol_error.h
+++ b/components/sync/protocol/sync_protocol_error.h
@@ -4,6 +4,7 @@
#ifndef COMPONENTS_SYNC_PROTOCOL_SYNC_PROTOCOL_ERROR_H_
#define COMPONENTS_SYNC_PROTOCOL_SYNC_PROTOCOL_ERROR_H_
+#include <memory>
#include <string>
#include "base/values.h"
@@ -88,7 +89,7 @@ struct SyncProtocolError {
SyncProtocolError();
SyncProtocolError(const SyncProtocolError& other);
~SyncProtocolError();
- base::DictionaryValue* ToValue() const;
+ std::unique_ptr<base::DictionaryValue> ToValue() const;
};
const char* GetSyncErrorTypeString(SyncProtocolErrorType type);
« no previous file with comments | « components/sync/js/js_event_details_unittest.cc ('k') | components/sync/protocol/sync_protocol_error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698