components/invalidation/public/invalidation.cc - Issue 2889163002: Remove raw DictionaryValue::Set in //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/public/invalidation.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)

Patch Set: Nits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/invalidation/public/invalidation.cc

diff --git a/components/invalidation/public/invalidation.cc b/components/invalidation/public/invalidation.cc

index 8877a23927ddfe86f7ea1bd17de8ebe0c8ddaddd..f69c0ec927f34934895247b9b336a187d69be612 100644

--- a/components/invalidation/public/invalidation.cc

+++ b/components/invalidation/public/invalidation.cc

@@ -140,7 +140,7 @@ bool Invalidation::Equals(const Invalidation& other) const {

std::unique_ptr<base::DictionaryValue> Invalidation::ToValue() const {

std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue());

- value->Set(kObjectIdKey, ObjectIdToValue(id_).release());

+ value->Set(kObjectIdKey, ObjectIdToValue(id_));

if (is_unknown_version_) {

value->SetBoolean(kIsUnknownVersionKey, true);

} else {