Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: components/sync/syncable/entry.h

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/syncable/base_node.cc ('k') | components/sync/syncable/entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/syncable/entry.h
diff --git a/components/sync/syncable/entry.h b/components/sync/syncable/entry.h
index 77a80c8c920877ce475c5bfc77854bd89eedcdcd..7669ebae4fad6e3bed2a75d83d1957426853ea09 100644
--- a/components/sync/syncable/entry.h
+++ b/components/sync/syncable/entry.h
@@ -8,10 +8,12 @@
#include <stddef.h>
#include <stdint.h>
+#include <memory>
#include <string>
#include <vector>
#include "base/macros.h"
+#include "base/values.h"
#include "components/sync/syncable/entry_kernel.h"
namespace syncer {
@@ -256,8 +258,8 @@ class Entry {
const EntryKernel GetKernelCopy() const { return *kernel_; }
// Dumps all entry info into a DictionaryValue and returns it.
- // Transfers ownership of the DictionaryValue to the caller.
- base::DictionaryValue* ToValue(Cryptographer* cryptographer) const;
+ std::unique_ptr<base::DictionaryValue> ToValue(
+ Cryptographer* cryptographer) const;
protected: // Don't allow creation on heap, except by sync API wrappers.
void* operator new(size_t size) { return (::operator new)(size); }
« no previous file with comments | « components/sync/syncable/base_node.cc ('k') | components/sync/syncable/entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698