Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: components/sync/engine/cycle/sync_cycle_snapshot.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/driver/about_sync_util.cc ('k') | components/sync/engine/events/protocol_event.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine/cycle/sync_cycle_snapshot.cc
diff --git a/components/sync/engine/cycle/sync_cycle_snapshot.cc b/components/sync/engine/cycle/sync_cycle_snapshot.cc
index 765e120e2f07227da2625bfb3e77b1bb6de527f5..fab6c650f57264a14a67ed58f803b5fb994188f6 100644
--- a/components/sync/engine/cycle/sync_cycle_snapshot.cc
+++ b/components/sync/engine/cycle/sync_cycle_snapshot.cc
@@ -95,7 +95,7 @@ std::unique_ptr<base::DictionaryValue> SyncCycleSnapshot::ToValue() const {
num_to_delete_entries_by_type_[i]);
const std::string model_type = ModelTypeToString(static_cast<ModelType>(i));
- counter_entries->Set(model_type, type_entries.release());
+ counter_entries->Set(model_type, std::move(type_entries));
}
value->Set("counter_entries", std::move(counter_entries));
return value;
« no previous file with comments | « components/sync/driver/about_sync_util.cc ('k') | components/sync/engine/events/protocol_event.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698