components/sync/syncable/base_node.h - Issue 2889163002: Remove raw DictionaryValue::Set in //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/syncable/base_node.h

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)

Patch Set: Nits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/syncable/base_node.h

diff --git a/components/sync/syncable/base_node.h b/components/sync/syncable/base_node.h

index 7e7c8ecd89b214646c2f173db32ed1ad02511e4a..ac53ace17e0842577dd7d92a61a49c9d9079b84b 100644

--- a/components/sync/syncable/base_node.h

+++ b/components/sync/syncable/base_node.h

@@ -171,7 +171,7 @@ class BaseNode {

const AttachmentIdList GetAttachmentIds() const;

// Returns a base::DictionaryValue serialization of this node.

- base::DictionaryValue* ToValue() const;

+ std::unique_ptr<base::DictionaryValue> ToValue() const;

protected:

BaseNode();