Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Side by Side Diff: components/sync/engine/events/protocol_event.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync/engine/events/protocol_event.h" 5 #include "components/sync/engine/events/protocol_event.h"
6 6
7 #include <utility>
8
9 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
10 8
11 namespace syncer { 9 namespace syncer {
12 10
13 ProtocolEvent::ProtocolEvent() {} 11 ProtocolEvent::ProtocolEvent() {}
14 12
15 ProtocolEvent::~ProtocolEvent() {} 13 ProtocolEvent::~ProtocolEvent() {}
16 14
17 std::unique_ptr<base::DictionaryValue> ProtocolEvent::ToValue( 15 std::unique_ptr<base::DictionaryValue> ProtocolEvent::ToValue(
18 const ProtocolEvent& event) { 16 const ProtocolEvent& event) {
19 auto dict = base::MakeUnique<base::DictionaryValue>(); 17 auto dict = base::MakeUnique<base::DictionaryValue>();
20 dict->SetDouble("time", event.GetTimestamp().ToJsTime()); 18 dict->SetDouble("time", event.GetTimestamp().ToJsTime());
21 dict->SetString("type", event.GetType()); 19 dict->SetString("type", event.GetType());
22 dict->SetString("details", event.GetDetails()); 20 dict->SetString("details", event.GetDetails());
23 dict->Set("proto", event.GetProtoMessage()); 21 dict->Set("proto", event.GetProtoMessage());
24 return dict; 22 return dict;
25 } 23 }
26 24
27 } // namespace syncer 25 } // namespace syncer
OLDNEW
« no previous file with comments | « components/sync/engine/cycle/sync_cycle_snapshot.cc ('k') | components/sync/engine_impl/js_mutation_event_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698