Chromium Code Reviews

Issue 92068: Move backend specific files to separate directories. (Closed)

Created:
11 years, 8 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Kasper Lund, Mads Ager (chromium)
CC:
v8-dev
Visibility:
Public.

Description

Move backend specific files to separate directories. Move ia32 and arm specific files to subdirectories to make it easier to add more backends.

Patch Set 1 #

Patch Set 2 : Added CPPPATH flag and made all includes use same base path. #

Unified diffs Side-by-side diffs Stats (+38505 lines, -38502 lines)
M SConstruct View 1 chunk +2 lines, -1 line 0 comments
M src/SConscript View 1 chunk +13 lines, -11 lines 0 comments
A src/arm/assembler-arm.h View 1 chunk +789 lines, -0 lines 0 comments
A src/arm/assembler-arm.cc View 1 chunk +1471 lines, -0 lines 0 comments
A src/arm/assembler-arm-inl.h View 1 chunk +249 lines, -0 lines 0 comments
A src/arm/builtins-arm.cc View 1 chunk +659 lines, -0 lines 0 comments
A src/arm/codegen-arm.h View 1 chunk +446 lines, -0 lines 0 comments
A src/arm/codegen-arm.cc View 1 chunk +5151 lines, -0 lines 0 comments
A src/arm/constants-arm.h View 1 chunk +240 lines, -0 lines 0 comments
A src/arm/cpu-arm.cc View 1 chunk +124 lines, -0 lines 0 comments
A src/arm/debug-arm.cc View 1 chunk +196 lines, -0 lines 0 comments
A src/arm/disasm-arm.cc View 1 chunk +900 lines, -0 lines 0 comments
A src/arm/frames-arm.h View 1 chunk +379 lines, -0 lines 0 comments
A src/arm/frames-arm.cc View 1 chunk +117 lines, -0 lines 0 comments
A src/arm/ic-arm.cc View 1 chunk +803 lines, -0 lines 0 comments
A src/arm/jump-target-arm.cc View 1 chunk +335 lines, -0 lines 0 comments
A src/arm/macro-assembler-arm.h View 1 chunk +313 lines, -0 lines 0 comments
A src/arm/macro-assembler-arm.cc View 1 chunk +941 lines, -0 lines 0 comments
A src/arm/regexp-macro-assembler-arm.h View 1 chunk +41 lines, -0 lines 0 comments
A src/arm/regexp-macro-assembler-arm.cc View 1 chunk +43 lines, -0 lines 0 comments
A src/arm/register-allocator-arm.cc View 1 chunk +96 lines, -0 lines 0 comments
A src/arm/simulator-arm.h View 1 chunk +204 lines, -0 lines 0 comments
A src/arm/simulator-arm.cc View 1 chunk +1687 lines, -0 lines 0 comments
A src/arm/stub-cache-arm.cc View 1 chunk +1124 lines, -0 lines 0 comments
A src/arm/virtual-frame-arm.h View 1 chunk +480 lines, -0 lines 0 comments
A src/arm/virtual-frame-arm.cc View 1 chunk +438 lines, -0 lines 0 comments
M src/assembler-arm.h View 1 chunk +0 lines, -789 lines 0 comments
M src/assembler-arm.cc View 1 chunk +0 lines, -1471 lines 0 comments
M src/assembler-arm-inl.h View 1 chunk +0 lines, -249 lines 0 comments
M src/assembler-ia32.h View 1 chunk +0 lines, -863 lines 0 comments
M src/assembler-ia32.cc View 1 chunk +0 lines, -2240 lines 0 comments
M src/assembler-ia32-inl.h View 1 chunk +0 lines, -302 lines 0 comments
M src/builtins-arm.cc View 1 chunk +0 lines, -659 lines 0 comments
M src/builtins-ia32.cc View 1 chunk +0 lines, -758 lines 0 comments
M src/codegen.h View 1 chunk +2 lines, -2 lines 0 comments
M src/codegen-arm.h View 1 chunk +0 lines, -446 lines 0 comments
M src/codegen-arm.cc View 1 chunk +0 lines, -5151 lines 0 comments
M src/codegen-ia32.h View 1 chunk +0 lines, -618 lines 0 comments
M src/codegen-ia32.cc View 1 chunk +0 lines, -7128 lines 0 comments
M src/constants-arm.h View 1 chunk +0 lines, -240 lines 0 comments
M src/cpu-arm.cc View 1 chunk +0 lines, -124 lines 0 comments
M src/cpu-ia32.cc View 1 chunk +0 lines, -65 lines 0 comments
M src/debug-arm.cc View 1 chunk +0 lines, -196 lines 0 comments
M src/debug-ia32.cc View 1 chunk +0 lines, -220 lines 0 comments
M src/disasm-arm.cc View 1 chunk +0 lines, -900 lines 0 comments
M src/disasm-ia32.cc View 1 chunk +0 lines, -1202 lines 0 comments
M src/execution.cc View 1 chunk +2 lines, -2 lines 0 comments
M src/frames-arm.h View 1 chunk +0 lines, -379 lines 0 comments
M src/frames-arm.cc View 1 chunk +0 lines, -117 lines 0 comments
M src/frames-ia32.h View 1 chunk +0 lines, -291 lines 0 comments
M src/frames-ia32.cc View 1 chunk +0 lines, -115 lines 0 comments
M src/frames-inl.h View 1 chunk +2 lines, -2 lines 0 comments
A src/ia32/assembler-ia32.h View 1 chunk +863 lines, -0 lines 0 comments
A src/ia32/assembler-ia32.cc View 1 chunk +2240 lines, -0 lines 0 comments
A src/ia32/assembler-ia32-inl.h View 1 chunk +302 lines, -0 lines 0 comments
A src/ia32/builtins-ia32.cc View 1 chunk +758 lines, -0 lines 0 comments
A src/ia32/codegen-ia32.h View 1 chunk +618 lines, -0 lines 0 comments
A src/ia32/codegen-ia32.cc View 1 chunk +7128 lines, -0 lines 0 comments
A src/ia32/cpu-ia32.cc View 1 chunk +65 lines, -0 lines 0 comments
A src/ia32/debug-ia32.cc View 1 chunk +220 lines, -0 lines 0 comments
A src/ia32/disasm-ia32.cc View 1 chunk +1202 lines, -0 lines 0 comments
A src/ia32/frames-ia32.h View 1 chunk +291 lines, -0 lines 0 comments
A src/ia32/frames-ia32.cc View 1 chunk +115 lines, -0 lines 0 comments
A src/ia32/ic-ia32.cc View 1 chunk +910 lines, -0 lines 0 comments
A src/ia32/jump-target-ia32.cc View 1 chunk +335 lines, -0 lines 0 comments
A src/ia32/macro-assembler-ia32.h View 1 chunk +371 lines, -0 lines 0 comments
A src/ia32/macro-assembler-ia32.cc View 1 chunk +1051 lines, -0 lines 0 comments
A src/ia32/regexp-macro-assembler-ia32.h View 1 chunk +285 lines, -0 lines 0 comments
A src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +1390 lines, -0 lines 0 comments
A src/ia32/register-allocator-ia32.cc View 1 chunk +130 lines, -0 lines 0 comments
A src/ia32/simulator-ia32.h View 1 chunk +47 lines, -0 lines 0 comments
A src/ia32/simulator-ia32.cc View 1 chunk +30 lines, -0 lines 0 comments
A src/ia32/stub-cache-ia32.cc View 1 chunk +1179 lines, -0 lines 0 comments
A src/ia32/virtual-frame-ia32.h View 1 chunk +493 lines, -0 lines 0 comments
A src/ia32/virtual-frame-ia32.cc View 1 chunk +1040 lines, -0 lines 0 comments
M src/ic-arm.cc View 1 chunk +0 lines, -803 lines 0 comments
M src/ic-ia32.cc View 1 chunk +0 lines, -910 lines 0 comments
M src/jsregexp.cc View 1 chunk +3 lines, -3 lines 0 comments
M src/jump-target-arm.cc View 1 chunk +0 lines, -335 lines 0 comments
M src/jump-target-ia32.cc View 1 chunk +0 lines, -335 lines 0 comments
M src/macro-assembler.h View 1 chunk +7 lines, -7 lines 0 comments
M src/macro-assembler-arm.h View 1 chunk +0 lines, -313 lines 0 comments
M src/macro-assembler-arm.cc View 1 chunk +0 lines, -941 lines 0 comments
M src/macro-assembler-ia32.h View 1 chunk +0 lines, -371 lines 0 comments
M src/macro-assembler-ia32.cc View 1 chunk +0 lines, -1051 lines 0 comments
M src/regexp-macro-assembler-arm.h View 1 chunk +0 lines, -41 lines 0 comments
M src/regexp-macro-assembler-arm.cc View 1 chunk +0 lines, -43 lines 0 comments
M src/regexp-macro-assembler-ia32.h View 1 chunk +0 lines, -285 lines 0 comments
M src/regexp-macro-assembler-ia32.cc View 1 chunk +0 lines, -1390 lines 0 comments
M src/register-allocator-arm.cc View 1 chunk +0 lines, -96 lines 0 comments
M src/register-allocator-ia32.cc View 1 chunk +0 lines, -130 lines 0 comments
M src/simulator-arm.h View 1 chunk +0 lines, -204 lines 0 comments
M src/simulator-arm.cc View 1 chunk +0 lines, -1687 lines 0 comments
M src/simulator-ia32.h View 1 chunk +0 lines, -47 lines 0 comments
M src/simulator-ia32.cc View 1 chunk +0 lines, -30 lines 0 comments
M src/stub-cache-arm.cc View 1 chunk +0 lines, -1124 lines 0 comments
M src/stub-cache-ia32.cc View 1 chunk +0 lines, -1179 lines 0 comments
M src/virtual-frame.h View 1 chunk +2 lines, -2 lines 0 comments
M src/virtual-frame-arm.h View 1 chunk +0 lines, -480 lines 0 comments
M src/virtual-frame-arm.cc View 1 chunk +0 lines, -438 lines 0 comments
M src/virtual-frame-ia32.h View 1 chunk +0 lines, -493 lines 0 comments
M src/virtual-frame-ia32.cc View 1 chunk +0 lines, -1040 lines 0 comments
M test/cctest/test-assembler-arm.cc View 1 chunk +2 lines, -2 lines 0 comments
M test/cctest/test-regexp.cc View 1 chunk +3 lines, -3 lines 0 comments
M tools/v8.xcodeproj/project.pbxproj View 39 chunks +157 lines, -157 lines 0 comments
M tools/visual_studio/v8_base.vcproj View 15 chunks +21 lines, -21 lines 0 comments

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Would moving backend specific files to separate directories be reasonable?
11 years, 8 months ago (2009-04-23 08:13:01 UTC) #1
Mads Ager (chromium)
11 years, 8 months ago (2009-04-23 08:41:17 UTC) #2
This sounds reasonable.  There are a few issues as discussed:

1. Be 100% sure that these files are moved with 'svn move' so svn will not get
confused by this (and make merging between versions hard).

2. We should use includes that are relative to the src directory.  In the
backend specific files, it would be nicer to have #include "ia32/file-ia32.h"
instead of "../file-ia32.h".

3. Once this is landed, we need to fix the chromium build system so we can push
that fix to chromium when this new V8 version is pushed to chromium.

Powered by Google App Engine