Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=eroman@chromium.org,hashimoto@chromium.org,jochen@chromium.org,piman@chromium.org,rdevlin.cronin@chromium.org,rogerta@chromium.org

Committed: https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4
Cr-Commit-Position: refs/heads/master@{#399362}

[dcheng, 2016-06-10 21:05:50]

Description was changed from

==========
Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
==========

to

==========
Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[dcheng, 2016-06-10 21:08:18]

dcheng@chromium.org changed reviewers:
+ thestig@chromium.org

[dcheng, 2016-06-10 21:08:19]

+thestig, mind doing the overall review? I'll TBR OWNERS after that.

The tool:
- Rewrites the original raw pointer declaration to use std::unique_ptr instead.
- Changes ListValue::Append() callsites to wrap it in std::move().

Headers were adjusted with another one of my scripts. I reviewed the changes
manually, and tweaked them as appropriate: the heuristic I'm using is unit tests
always include all their dependencies, while .cc files are allowed to depend on
#includes in their 'primary' header.

[Lei Zhang, 2016-06-10 21:20:53]

I spot checked and it looks ok. The case I'm concerned about is:

Value* value = new Value();
list.Append(value);
value->Func();

https://codereview.chromium.org/2058233002/diff/1/dbus/values_util_unittest.cc
File dbus/values_util_unittest.cc (right):

https://codereview.chromium.org/2058233002/diff/1/dbus/values_util_unittest.c...
dbus/values_util_unittest.cc:631: test_list.Append(std::move(list_value));      
 // takes ownership
no need for ownership comments

[Lei Zhang, 2016-06-10 21:29:39]

On 2016/06/10 21:20:53, Lei Zhang wrote:
> I spot checked and it looks ok. The case I'm concerned about is:
> 
> Value* value = new Value();
> list.Append(value);
> value->Func();

I spot checked some more and didn't find any, so crossing my fingers and lgtm.

[dcheng, 2016-06-10 21:30:44]

On 2016/06/10 21:20:53, Lei Zhang wrote:
> I spot checked and it looks ok. The case I'm concerned about is:
> 
> Value* value = new Value();
> list.Append(value);
> value->Func();

The tool actually understands use-after-move: if it encounters a use-after-move
situation (e.g. the variable is touched in any way after being passed to
Append() other than being re-assigned the result of a new expression), then it
won't rewrite it.

https://codereview.chromium.org/2058233002/diff/1/dbus/values_util_unittest.cc
File dbus/values_util_unittest.cc (right):

https://codereview.chromium.org/2058233002/diff/1/dbus/values_util_unittest.c...
dbus/values_util_unittest.cc:631: test_list.Append(std::move(list_value));      
 // takes ownership
On 2016/06/10 21:20:53, Lei Zhang wrote:
> no need for ownership comments

Done. Sadly, the tool's not smart enough to parse comments and remove
unnecessary ones =)

I did a quick sweep through to clean up the obvious ones.

[dcheng, 2016-06-10 23:51:23]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-06-10 23:51:24]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2058233002/#ps20001
(title: "less comments more ownership")

[commit-bot: I haz the power, 2016-06-10 23:52:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058233002/20001

[commit-bot: I haz the power, 2016-06-11 00:04:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-11 00:04:35]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-06-11 00:25:49]

Description was changed from

==========
Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[dcheng, 2016-06-11 00:25:49]

dcheng@chromium.org changed reviewers:
+ jochen@chromium.org, piman@chromium.org, rdevlin.cronin@chromium.org,
rogerta@chromium.org

[dcheng, 2016-06-11 00:28:53]

Description was changed from

==========
Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=eroman@chromium.org,hashimoto@chromium.org,jochen@chromium.org,piman@chro...
==========

[dcheng, 2016-06-11 00:28:53]

dcheng@chromium.org changed reviewers:
+ eroman@chromium.org, hashimoto@chromium.org

[dcheng, 2016-06-11 00:29:08]

TBRing various OWNERS.

[dcheng, 2016-06-11 00:29:15]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-06-11 00:29:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058233002/20001

[Devlin, 2016-06-11 00:51:55]

extensions + json_schema_compiler lgtm

[commit-bot: I haz the power, 2016-06-11 03:42:15]

Description was changed from

==========
Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=eroman@chromium.org,hashimoto@chromium.org,jochen@chromium.org,piman@chro...
==========

to

==========
Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=eroman@chromium.org,hashimoto@chromium.org,jochen@chromium.org,piman@chro...
==========

[commit-bot: I haz the power, 2016-06-11 03:42:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-11 03:42:23]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-11 03:45:23]

Description was changed from

==========
Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=eroman@chromium.org,hashimoto@chromium.org,jochen@chromium.org,piman@chro...
==========

to

==========
Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=eroman@chromium.org,hashimoto@chromium.org,jochen@chromium.org,piman@chro...

Committed: https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4
Cr-Commit-Position: refs/heads/master@{#399362}
==========

[commit-bot: I haz the power, 2016-06-11 03:45:26]

Patchset 2 (id:??) landed as
https://crrev.com/98e96a7390e63333cd5e1a5128ef17e489cbfbb4
Cr-Commit-Position: refs/heads/master@{#399362}

[eroman, 2016-06-11 05:58:11]

net LGTM