Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3783)

Unified Diff: chrome/browser/metrics/plugin_metrics_provider.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: less comments more ownership Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media_galleries/media_galleries_test_util.cc ('k') | chrome/browser/net/predictor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/plugin_metrics_provider.cc
diff --git a/chrome/browser/metrics/plugin_metrics_provider.cc b/chrome/browser/metrics/plugin_metrics_provider.cc
index cfff039a19ca4c68eb51e59feeef14dab3e992ef..ca0c3beb2c414bc160dfe6f8297c260951e702d9 100644
--- a/chrome/browser/metrics/plugin_metrics_provider.cc
+++ b/chrome/browser/metrics/plugin_metrics_provider.cc
@@ -6,7 +6,9 @@
#include <stddef.h>
+#include <memory>
#include <string>
+#include <utility>
#include "base/stl_util.h"
#include "base/strings/utf_string_conversions.h"
@@ -268,7 +270,8 @@ void PluginMetricsProvider::RecordCurrentState() {
if (!IsPluginProcess(stats.process_type))
continue;
- base::DictionaryValue* plugin_dict = new base::DictionaryValue;
+ std::unique_ptr<base::DictionaryValue> plugin_dict(
+ new base::DictionaryValue);
plugin_dict->SetString(prefs::kStabilityPluginName, cache_iter->first);
plugin_dict->SetInteger(prefs::kStabilityPluginLaunches,
@@ -279,7 +282,7 @@ void PluginMetricsProvider::RecordCurrentState() {
stats.instances);
plugin_dict->SetInteger(prefs::kStabilityPluginLoadingErrors,
stats.loading_errors);
- plugins->Append(plugin_dict);
+ plugins->Append(std::move(plugin_dict));
}
child_process_stats_buffer_.clear();
}
« no previous file with comments | « chrome/browser/media_galleries/media_galleries_test_util.cc ('k') | chrome/browser/net/predictor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698