Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1883)

Unified Diff: chrome/browser/profile_resetter/resettable_settings_snapshot.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: less comments more ownership Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profile_resetter/resettable_settings_snapshot.cc
diff --git a/chrome/browser/profile_resetter/resettable_settings_snapshot.cc b/chrome/browser/profile_resetter/resettable_settings_snapshot.cc
index f676734b5999b092247b09220414c6ea5d77d78f..6df47f2f50a31f83a21fb1868d468e1707ba172b 100644
--- a/chrome/browser/profile_resetter/resettable_settings_snapshot.cc
+++ b/chrome/browser/profile_resetter/resettable_settings_snapshot.cc
@@ -4,6 +4,9 @@
#include "chrome/browser/profile_resetter/resettable_settings_snapshot.h"
+#include <memory>
+#include <utility>
+
#include "base/guid.h"
#include "base/md5.h"
#include "base/strings/string_util.h"
@@ -35,10 +38,10 @@ template <class StringType>
void AddPair(base::ListValue* list,
const base::string16& key,
const StringType& value) {
- base::DictionaryValue* results = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> results(new base::DictionaryValue());
results->SetString("key", key);
results->SetString("value", value);
- list->Append(results);
+ list->Append(std::move(results));
}
} // namespace
« no previous file with comments | « chrome/browser/prerender/prerender_history.cc ('k') | chrome/browser/speech/extension_api/tts_extension_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698