chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/metadata_database.cc ('k') | chrome/browser/ui/webui/certificate_viewer_webui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc

index 955862405813d3dc98a849719c3f2466800fc203..26064fe5f969e0f68663172a259a933861cdc7cb 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc

@@ -8,6 +8,7 @@

#include <memory>

#include <string>

+#include <utility>

#include <vector>

#include "base/compiler_specific.h"

@@ -358,11 +359,11 @@ TEST_F(BookmarkContextMenuTest, ShowManagedBookmarks) {

EXPECT_TRUE(menu->GetMenuItemByID(IDC_BOOKMARK_BAR_NEW_FOLDER)->visible());

// Now set the managed bookmarks policy.

- base::DictionaryValue* dict = new base::DictionaryValue;

+ std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue);

dict->SetString("name", "Google");

dict->SetString("url", "http://google.com");

base::ListValue list;

- list.Append(dict);

+ list.Append(std::move(dict));

EXPECT_TRUE(managed->managed_node()->empty());

profile_->GetPrefs()->Set(bookmarks::prefs::kManagedBookmarks, list);

EXPECT_FALSE(managed->managed_node()->empty());