Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4407)

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: less comments more ownership Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/proxy/proxy_api.cc
diff --git a/chrome/browser/extensions/api/proxy/proxy_api.cc b/chrome/browser/extensions/api/proxy/proxy_api.cc
index 65f197a1b348e0e6ae7913628d0a0ceeee1b9417..e52ebb19868a4db2b40af0abcca119e2e698acaf 100644
--- a/chrome/browser/extensions/api/proxy/proxy_api.cc
+++ b/chrome/browser/extensions/api/proxy/proxy_api.cc
@@ -6,6 +6,7 @@
#include "chrome/browser/extensions/api/proxy/proxy_api.h"
+#include <memory>
#include <utility>
#include "base/json/json_writer.h"
@@ -40,11 +41,11 @@ void ProxyEventRouter::OnProxyError(
void* profile,
int error_code) {
std::unique_ptr<base::ListValue> args(new base::ListValue());
- base::DictionaryValue* dict = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->SetBoolean(keys::kProxyEventFatal, true);
dict->SetString(keys::kProxyEventError, net::ErrorToString(error_code));
dict->SetString(keys::kProxyEventDetails, std::string());
- args->Append(dict);
+ args->Append(std::move(dict));
if (profile) {
event_router->DispatchEventToRenderers(
@@ -63,7 +64,7 @@ void ProxyEventRouter::OnPACScriptError(
int line_number,
const base::string16& error) {
std::unique_ptr<base::ListValue> args(new base::ListValue());
- base::DictionaryValue* dict = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->SetBoolean(keys::kProxyEventFatal, false);
dict->SetString(keys::kProxyEventError,
net::ErrorToString(net::ERR_PAC_SCRIPT_FAILED));
@@ -76,7 +77,7 @@ void ProxyEventRouter::OnPACScriptError(
error_msg = base::UTF16ToUTF8(error);
}
dict->SetString(keys::kProxyEventDetails, error_msg);
- args->Append(dict);
+ args->Append(std::move(dict));
if (profile) {
event_router->DispatchEventToRenderers(

Powered by Google App Engine
This is Rietveld 408576698