chrome/browser/devtools/devtools_ui_bindings.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_targets_ui.cc ('k') | chrome/browser/extensions/api/autotest_private/autotest_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_ui_bindings.cc

diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc

index f901b8fa58d2a51103126e75f2ec5811f881d476..e083cfbf8aa6f592c6766830864c135922a40f1e 100644

--- a/chrome/browser/devtools/devtools_ui_bindings.cc

+++ b/chrome/browser/devtools/devtools_ui_bindings.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/devtools/devtools_ui_bindings.h"

#include <stddef.h>

#include <utility>

#include "base/base64.h"

@@ -1007,7 +1008,8 @@ void DevToolsUIBindings::AddDevToolsExtensionsToClient() {

if (extensions::chrome_manifest_urls::GetDevToolsPage(extension.get())

.is_empty())

continue;

- base::DictionaryValue* extension_info = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> extension_info(

+ new base::DictionaryValue());

extension_info->Set(

"startPage",

new base::StringValue(extensions::chrome_manifest_urls::GetDevToolsPage(

@@ -1017,7 +1019,7 @@ void DevToolsUIBindings::AddDevToolsExtensionsToClient() {

new base::FundamentalValue(

extension->permissions_data()->HasAPIPermission(

extensions::APIPermission::kExperimental)));

- results.Append(extension_info);

+ results.Append(std::move(extension_info));

}

CallClientFunction("DevToolsAPI.addExtensions",

&results, NULL, NULL);