Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5881)

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: less comments more ownership Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
index 4a6c98839b210e94f7bfd1f4d382b68295f11045..8c80134a088c8174fbee5e41f59562a0c57a04ad 100644
--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
@@ -4,6 +4,9 @@
#include <stddef.h>
+#include <memory>
+#include <utility>
+
#include "base/json/json_writer.h"
#include "base/strings/string_split.h"
#include "base/strings/stringprintf.h"
@@ -49,16 +52,17 @@ std::string ParamsToString(const base::ListValue& parameters) {
}
void InitializeTestMetaData(base::ListValue* parameters) {
- base::DictionaryValue* meta_data_entry = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> meta_data_entry(
+ new base::DictionaryValue());
meta_data_entry->SetString("key", kTestLoggingSessionIdKey);
meta_data_entry->SetString("value", kTestLoggingSessionIdValue);
- base::ListValue* meta_data = new base::ListValue();
- meta_data->Append(meta_data_entry);
- meta_data_entry = new base::DictionaryValue();
+ std::unique_ptr<base::ListValue> meta_data(new base::ListValue());
+ meta_data->Append(std::move(meta_data_entry));
+ meta_data_entry.reset(new base::DictionaryValue());
meta_data_entry->SetString("key", "url");
meta_data_entry->SetString("value", kTestLoggingUrl);
- meta_data->Append(meta_data_entry);
- parameters->Append(meta_data);
+ meta_data->Append(std::move(meta_data_entry));
+ parameters->Append(std::move(meta_data));
}
class WebrtcLoggingPrivateApiTest : public ExtensionApiTest {
@@ -81,10 +85,11 @@ class WebrtcLoggingPrivateApiTest : public ExtensionApiTest {
}
void AppendTabIdAndUrl(base::ListValue* parameters) {
- base::DictionaryValue* request_info = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> request_info(
+ new base::DictionaryValue());
request_info->SetInteger(
"tabId", extensions::ExtensionTabUtil::GetTabId(web_contents()));
- parameters->Append(request_info);
+ parameters->Append(std::move(request_info));
parameters->AppendString(web_contents()->GetURL().GetOrigin().spec());
}

Powered by Google App Engine
This is Rietveld 408576698