Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

components/policy/core/common/schema_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/schema.h"
 
 #include <stddef.h>
 
 #include <memory>
+#include <utility>
 
 #include "base/macros.h"
 #include "base/strings/stringprintf.h"
 #include "components/policy/core/common/schema_internal.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace policy {
 
 namespace {
 
@@ skipping 743 matching lines @@
     root.Remove("Object.one", NULL);
   }
 
   // Tests on ArrayOfObjects.
   {
     Schema subschema = schema.GetProperty("ArrayOfObjects");
     ASSERT_TRUE(subschema.valid());
     base::ListValue root;
 
     // Unknown property.
-    base::DictionaryValue* dict_value = new base::DictionaryValue();
+    std::unique_ptr<base::DictionaryValue> dict_value(
+        new base::DictionaryValue());
     dict_value->SetBoolean("three", true);
-    root.Append(dict_value);  // Pass ownership to root.
+    root.Append(std::move(dict_value));
     TestSchemaValidation(subschema, root, SCHEMA_STRICT, false);
     TestSchemaValidation(subschema, root, SCHEMA_ALLOW_UNKNOWN_TOPLEVEL, false);
     TestSchemaValidation(subschema, root, SCHEMA_ALLOW_UNKNOWN, true);
     TestSchemaValidation(subschema, root, SCHEMA_ALLOW_INVALID_TOPLEVEL, true);
     TestSchemaValidation(subschema, root, SCHEMA_ALLOW_INVALID, true);
     TestSchemaValidationWithPath(subschema, root, "items[0]");
     root.Remove(root.GetSize() - 1, NULL);
 
     // Invalid property.
-    dict_value = new base::DictionaryValue();
+    dict_value.reset(new base::DictionaryValue());
     dict_value->SetBoolean("two", true);
-    root.Append(dict_value);  // Pass ownership to root.
+    root.Append(std::move(dict_value));
     TestSchemaValidation(subschema, root, SCHEMA_STRICT, false);
     TestSchemaValidation(subschema, root, SCHEMA_ALLOW_UNKNOWN_TOPLEVEL, false);
     TestSchemaValidation(subschema, root, SCHEMA_ALLOW_UNKNOWN, false);
     TestSchemaValidation(subschema, root, SCHEMA_ALLOW_INVALID_TOPLEVEL, true);
     TestSchemaValidation(subschema, root, SCHEMA_ALLOW_INVALID, true);
     TestSchemaValidationWithPath(subschema, root, "items[0].two");
     root.Remove(root.GetSize() - 1, NULL);
   }
 
   // Tests on ObjectOfArray.
@@ skipping 23 matching lines @@
     TestSchemaValidationWithPath(subschema, root, "List.items[1]");
   }
 
   // Tests on ArrayOfObjectOfArray.
   {
     Schema subschema = schema.GetProperty("ArrayOfObjectOfArray");
     ASSERT_TRUE(subschema.valid());
     base::ListValue root;
 
     base::ListValue* list_value = new base::ListValue();
-    base::DictionaryValue* dict_value = new base::DictionaryValue();
+    std::unique_ptr<base::DictionaryValue> dict_value(
+        new base::DictionaryValue());
     dict_value->Set("List", list_value);  // Pass ownership to dict_value.
-    root.Append(dict_value);  // Pass ownership to root.
+    root.Append(std::move(dict_value));
 
     // Test that there are not errors here.
     list_value->AppendString("blabla");
     TestSchemaValidation(subschema, root, SCHEMA_STRICT, true);
     TestSchemaValidation(subschema, root, SCHEMA_ALLOW_UNKNOWN_TOPLEVEL, true);
     TestSchemaValidation(subschema, root, SCHEMA_ALLOW_UNKNOWN, true);
     TestSchemaValidation(subschema, root, SCHEMA_ALLOW_INVALID_TOPLEVEL, true);
     TestSchemaValidation(subschema, root, SCHEMA_ALLOW_INVALID, true);
 
     // Invalid list item.
@@ skipping 330 matching lines @@
 
   EXPECT_FALSE(ParseFails(SchemaObjectWrapper(
       "{"
       "  \"type\": \"integer\","
       "  \"minimum\": 10,"
       "  \"maximum\": 20"
       "}")));
 }
 
 }  // namespace policy