chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc ('k') | chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc

diff --git a/chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc b/chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc

index 854f57a2055720b0cfde7b60002510a9efbb869d..7d7fbe025f737d178e1ba6e2d97de06075e5ddaf 100644

--- a/chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc

+++ b/chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc

@@ -8,6 +8,7 @@

#include <memory>

#include <string>

+#include <utility>

#include "base/callback.h"

#include "base/json/json_writer.h"

@@ -44,11 +45,12 @@ const char* kURLs[] = {

std::string BuildResponse(bool is_porn) {

base::DictionaryValue dict;

- base::DictionaryValue* classification_dict = new base::DictionaryValue;

+ std::unique_ptr<base::DictionaryValue> classification_dict(

+ new base::DictionaryValue);

if (is_porn)

classification_dict->SetBoolean("pornography", is_porn);

base::ListValue* classifications_list = new base::ListValue;

- classifications_list->Append(classification_dict);

+ classifications_list->Append(std::move(classification_dict));

dict.SetWithoutPathExpansion("classifications", classifications_list);

std::string result;

base::JSONWriter::Write(dict, &result);