Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: components/policy/core/common/configuration_policy_provider_test.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: less comments more ownership Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/flags_ui/flags_state.cc ('k') | components/policy/core/common/schema_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/policy/core/common/configuration_policy_provider_test.cc
diff --git a/components/policy/core/common/configuration_policy_provider_test.cc b/components/policy/core/common/configuration_policy_provider_test.cc
index 6681086fd12b648e1fc5aea9171cedffe26d62d1..0f27c2ff229d0f5143773f139f7846906227445c 100644
--- a/components/policy/core/common/configuration_policy_provider_test.cc
+++ b/components/policy/core/common/configuration_policy_provider_test.cc
@@ -4,6 +4,9 @@
#include "components/policy/core/common/configuration_policy_provider_test.h"
+#include <memory>
+#include <utility>
+
#include "base/bind.h"
#include "base/callback.h"
#include "base/memory/ptr_util.h"
@@ -301,14 +304,14 @@ TEST_P(ConfigurationPolicyProviderTest, DictionaryValue) {
base::DictionaryValue* dict = new base::DictionaryValue();
dict->SetString("sub", "value");
list = new base::ListValue();
- base::DictionaryValue* sub = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> sub(new base::DictionaryValue());
sub->SetInteger("aaa", 111);
sub->SetInteger("bbb", 222);
- list->Append(sub);
- sub = new base::DictionaryValue();
+ list->Append(std::move(sub));
+ sub.reset(new base::DictionaryValue());
sub->SetString("ccc", "333");
sub->SetString("ddd", "444");
- list->Append(sub);
+ list->Append(std::move(sub));
dict->Set("sublist", list);
expected_value.Set("dictionary", dict);
@@ -364,10 +367,10 @@ TEST_P(Configuration3rdPartyPolicyProviderTest, Load3rdParty) {
base::ListValue* list = new base::ListValue();
for (int i = 0; i < 2; ++i) {
- base::DictionaryValue* dict = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->SetInteger("subdictindex", i);
dict->Set("subdict", policy_dict.DeepCopy());
- list->Append(dict);
+ list->Append(std::move(dict));
}
policy_dict.Set("list", list);
policy_dict.Set("dict", policy_dict.DeepCopy());
« no previous file with comments | « components/flags_ui/flags_state.cc ('k') | components/policy/core/common/schema_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698