chrome/browser/extensions/api/content_settings/content_settings_api.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_api.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc ('k') | chrome/browser/extensions/api/content_settings/content_settings_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/content_settings/content_settings_api.cc

diff --git a/chrome/browser/extensions/api/content_settings/content_settings_api.cc b/chrome/browser/extensions/api/content_settings/content_settings_api.cc

index a7c2a8443b865123f43464e6f89d801d156ed670..75351e807674364c4f3dffc7689d539c8e37bdb9 100644

--- a/chrome/browser/extensions/api/content_settings/content_settings_api.cc

+++ b/chrome/browser/extensions/api/content_settings/content_settings_api.cc

@@ -6,6 +6,7 @@

#include <memory>

#include <set>

+#include <utility>

#include <vector>

#include "base/bind.h"

@@ -316,10 +317,10 @@ void ContentSettingsContentSettingGetResourceIdentifiersFunction::OnGotPlugins(

continue;

group_identifiers.insert(group_identifier);

- base::DictionaryValue* dict = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());

dict->SetString(keys::kIdKey, group_identifier);

dict->SetString(keys::kDescriptionKey, plugin_metadata->name());

- list->Append(dict);

+ list->Append(std::move(dict));

}

SetResult(std::move(list));

BrowserThread::PostTask(