Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
+#include <memory>
+#include <utility>
+
 #include "base/json/json_writer.h"
 #include "base/strings/string_split.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/media/webrtc_log_uploader.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ skipping 25 matching lines @@
 static const char kTestLoggingSessionIdValue[] = "0123456789abcdef";
 static const char kTestLoggingUrl[] = "dummy url string";
 
 std::string ParamsToString(const base::ListValue& parameters) {
   std::string parameter_string;
   EXPECT_TRUE(base::JSONWriter::Write(parameters, &parameter_string));
   return parameter_string;
 }
 
 void InitializeTestMetaData(base::ListValue* parameters) {
-  base::DictionaryValue* meta_data_entry = new base::DictionaryValue();
+  std::unique_ptr<base::DictionaryValue> meta_data_entry(
+      new base::DictionaryValue());
   meta_data_entry->SetString("key", kTestLoggingSessionIdKey);
   meta_data_entry->SetString("value", kTestLoggingSessionIdValue);
-  base::ListValue* meta_data = new base::ListValue();
-  meta_data->Append(meta_data_entry);
-  meta_data_entry = new base::DictionaryValue();
+  std::unique_ptr<base::ListValue> meta_data(new base::ListValue());
+  meta_data->Append(std::move(meta_data_entry));
+  meta_data_entry.reset(new base::DictionaryValue());
   meta_data_entry->SetString("key", "url");
   meta_data_entry->SetString("value", kTestLoggingUrl);
-  meta_data->Append(meta_data_entry);
-  parameters->Append(meta_data);
+  meta_data->Append(std::move(meta_data_entry));
+  parameters->Append(std::move(meta_data));
 }
 
 class WebrtcLoggingPrivateApiTest : public ExtensionApiTest {
  protected:
   void SetUp() override {
     ExtensionApiTest::SetUp();
     extension_ = extensions::test_util::CreateEmptyExtension();
   }
 
   template<typename T>
   scoped_refptr<T> CreateFunction() {
     scoped_refptr<T> function(new T());
     function->set_extension(extension_.get());
     function->set_has_callback(true);
     return function;
   }
 
   content::WebContents* web_contents() {
     return browser()->tab_strip_model()->GetActiveWebContents();
   }
 
   void AppendTabIdAndUrl(base::ListValue* parameters) {
-    base::DictionaryValue* request_info = new base::DictionaryValue();
+    std::unique_ptr<base::DictionaryValue> request_info(
+        new base::DictionaryValue());
     request_info->SetInteger(
         "tabId", extensions::ExtensionTabUtil::GetTabId(web_contents()));
-    parameters->Append(request_info);
+    parameters->Append(std::move(request_info));
     parameters->AppendString(web_contents()->GetURL().GetOrigin().spec());
   }
 
   bool RunFunction(UIThreadExtensionFunction* function,
                    const base::ListValue& parameters,
                    bool expect_results) {
     std::unique_ptr<base::Value> result(utils::RunFunctionAndReturnSingleResult(
         function, ParamsToString(parameters), browser()));
     if (expect_results) {
       EXPECT_TRUE(result.get());
@@ skipping 338 matching lines @@
   ASSERT_TRUE(StartAudioDebugRecordings(0));
   ASSERT_TRUE(StopAudioDebugRecordings());
 }
 
 IN_PROC_BROWSER_TEST_F(WebrtcLoggingPrivateApiTest,
                        TestStartTimedAudioDebugRecordings) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       switches::kEnableAudioDebugRecordingsFromExtension);
   ASSERT_TRUE(StartAudioDebugRecordings(1));
 }