chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc ('k') | chrome/browser/sync_file_system/drive_backend/metadata_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc b/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

index 9b38f3e47e9b75c7acdcb0821f21be81e4e8a77e..c17703f15abe63a8d4c3ceaa15452834ddf6d34c 100644

--- a/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

+++ b/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

@@ -4,6 +4,7 @@

#include <stddef.h>

+#include <memory>

#include <utility>

#include "base/macros.h"

@@ -2207,11 +2208,11 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ManagedBookmarks) {

// Set the ManagedBookmarks policy for the first Profile,

// which will add one new managed bookmark.

- base::DictionaryValue* bookmark = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> bookmark(new base::DictionaryValue());

bookmark->SetString("name", "Managed bookmark");

bookmark->SetString("url", "youtube.com");

std::unique_ptr<base::ListValue> list(new base::ListValue());

- list->Append(bookmark);

+ list->Append(std::move(bookmark));

policy::PolicyMap policy;

policy.Set(policy::key::kManagedBookmarks, policy::POLICY_LEVEL_MANDATORY,

policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,