Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3271)

Unified Diff: chrome/browser/extensions/api/font_settings/font_settings_api.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: less comments more ownership Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/font_settings/font_settings_api.cc
diff --git a/chrome/browser/extensions/api/font_settings/font_settings_api.cc b/chrome/browser/extensions/api/font_settings/font_settings_api.cc
index 376a1763d599cab51907d9c86e2653bc952a0e02..c05bcfaeebf200fc6d62d180fac974f71a988097 100644
--- a/chrome/browser/extensions/api/font_settings/font_settings_api.cc
+++ b/chrome/browser/extensions/api/font_settings/font_settings_api.cc
@@ -340,10 +340,11 @@ bool FontSettingsGetFontListFunction::CopyFontsToResult(
return false;
}
- base::DictionaryValue* font_name = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> font_name(
+ new base::DictionaryValue());
font_name->Set(kFontIdKey, new base::StringValue(name));
font_name->Set(kDisplayNameKey, new base::StringValue(localized_name));
- result->Append(font_name);
+ result->Append(std::move(font_name));
}
SetResult(std::move(result));

Powered by Google App Engine
This is Rietveld 408576698