chrome/browser/media_galleries/media_galleries_preferences.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/media_galleries_preferences.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc ('k') | chrome/browser/media_galleries/media_galleries_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/media_galleries_preferences.cc

diff --git a/chrome/browser/media_galleries/media_galleries_preferences.cc b/chrome/browser/media_galleries/media_galleries_preferences.cc

index 2a4d8d0f5171d04cb6419134e0061b41eb9992a4..ad8c7aaa11b31dac016749b69edf99436a83a711 100644

--- a/chrome/browser/media_galleries/media_galleries_preferences.cc

+++ b/chrome/browser/media_galleries/media_galleries_preferences.cc

@@ -6,6 +6,9 @@

#include <stddef.h>

+#include <memory>

+#include <utility>

#include "base/base_paths_posix.h"

#include "base/callback.h"

#include "base/i18n/time_formatting.h"

@@ -1350,10 +1353,10 @@ bool MediaGalleriesPreferences::SetGalleryPermissionInPrefs(

}

// ...Otherwise, add a new entry for the gallery.

- base::DictionaryValue* dict = new base::DictionaryValue;

+ std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue);

dict->SetString(kMediaGalleryIdKey, base::Uint64ToString(gallery_id));

dict->SetBoolean(kMediaGalleryHasPermissionKey, has_access);

- permissions->Append(dict);

+ permissions->Append(std::move(dict));

return true;

}