chrome/browser/extensions/api/media_galleries/media_galleries_api.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/font_settings/font_settings_api.cc ('k') | chrome/browser/extensions/api/proxy/proxy_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

diff --git a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

index 5d4fb1df1b2240a5c76b225c617ec90c091f9124..6daf3bdca3e0966d60ec24f60f9b690dc0ac3460 100644

--- a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

+++ b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

@@ -711,14 +711,15 @@ void MediaGalleriesGetMetadataFunction::ConstructNextBlob(

metadata::AttachedImage* current_image =

&(*attached_images)[blob_uuids->size()];

- base::DictionaryValue* attached_image = new base::DictionaryValue;

+ std::unique_ptr<base::DictionaryValue> attached_image(

+ new base::DictionaryValue);

attached_image->Set(kBlobUUIDKey, new base::StringValue(

current_blob->GetUUID()));

attached_image->Set(kTypeKey, new base::StringValue(

current_image->type));

attached_image->Set(kSizeKey, new base::FundamentalValue(

base::checked_cast<int>(current_image->data.size())));

- attached_images_list->Append(attached_image);

+ attached_images_list->Append(std::move(attached_image));

blob_uuids->push_back(current_blob->GetUUID());

extensions::BlobHolder* holder =