Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6394)

Unified Diff: chrome/browser/speech/extension_api/tts_extension_api.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: less comments more ownership Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/speech/extension_api/tts_extension_api.cc
diff --git a/chrome/browser/speech/extension_api/tts_extension_api.cc b/chrome/browser/speech/extension_api/tts_extension_api.cc
index 7f14336d88710219ee7971b2394ead7675fcacb4..0bab877437d16a878da8519407a30708ac0a8612 100644
--- a/chrome/browser/speech/extension_api/tts_extension_api.cc
+++ b/chrome/browser/speech/extension_api/tts_extension_api.cc
@@ -5,6 +5,8 @@
#include "chrome/browser/speech/extension_api/tts_extension_api.h"
#include <stddef.h>
+
+#include <memory>
#include <string>
#include <utility>
@@ -321,7 +323,8 @@ bool TtsGetVoicesFunction::RunSync() {
std::unique_ptr<base::ListValue> result_voices(new base::ListValue());
for (size_t i = 0; i < voices.size(); ++i) {
const VoiceData& voice = voices[i];
- base::DictionaryValue* result_voice = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> result_voice(
+ new base::DictionaryValue());
result_voice->SetString(constants::kVoiceNameKey, voice.name);
result_voice->SetBoolean(constants::kRemoteKey, voice.remote);
if (!voice.lang.empty())
@@ -341,7 +344,7 @@ bool TtsGetVoicesFunction::RunSync() {
}
result_voice->Set(constants::kEventTypesKey, event_types);
- result_voices->Append(result_voice);
+ result_voices->Append(std::move(result_voice));
}
SetResult(std::move(result_voices));

Powered by Google App Engine
This is Rietveld 408576698