chrome/browser/extensions/api/content_settings/content_settings_store.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_store.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/content_settings/content_settings_api.cc ('k') | chrome/browser/extensions/api/cookies/cookies_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/content_settings/content_settings_store.cc

diff --git a/chrome/browser/extensions/api/content_settings/content_settings_store.cc b/chrome/browser/extensions/api/content_settings/content_settings_store.cc

index 8f9b1c6c00cc6a87eddc4e3da5417044a7a9efc5..46ca488ab9b289d2715b2b55dcb2aa9bcbc2d2d3 100644

--- a/chrome/browser/extensions/api/content_settings/content_settings_store.cc

+++ b/chrome/browser/extensions/api/content_settings/content_settings_store.cc

@@ -260,7 +260,8 @@ base::ListValue* ContentSettingsStore::GetSettingsForExtension(

NULL)); // We already hold the lock.

while (rule_iterator->HasNext()) {

const Rule& rule = rule_iterator->Next();

- base::DictionaryValue* setting_dict = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> setting_dict(

+ new base::DictionaryValue());

setting_dict->SetString(keys::kPrimaryPatternKey,

rule.primary_pattern.ToString());

setting_dict->SetString(keys::kSecondaryPatternKey,

@@ -278,7 +279,7 @@ base::ListValue* ContentSettingsStore::GetSettingsForExtension(

DCHECK(!setting_string.empty());

setting_dict->SetString(keys::kContentSettingKey, setting_string);

- settings->Append(setting_dict);

+ settings->Append(std::move(setting_dict));

}

return settings;