chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc ('k') | chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

index 726a8d96f16f4f08e46aab062538baadcf9437b9..7b5a2bbfda8911ae6b55d8c45934f2c697fd2d95 100644

--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

@@ -2,6 +2,9 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include <memory>

+#include <utility>

#include "base/command_line.h"

#include "base/json/json_writer.h"

#include "base/strings/string_number_conversions.h"

@@ -90,10 +93,11 @@ class WebrtcEventLogApiTest : public WebRtcTestBase {

void AppendTabIdAndUrl(base::ListValue* parameters,

content::WebContents* tab) {

- base::DictionaryValue* request_info = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> request_info(

+ new base::DictionaryValue());

request_info->SetInteger("tabId",

extensions::ExtensionTabUtil::GetTabId(tab));

- parameters->Append(request_info);

+ parameters->Append(std::move(request_info));

parameters->AppendString(tab->GetURL().GetOrigin().spec());

}