Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: chrome/browser/media_galleries/media_galleries_test_util.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: less comments more ownership Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/media_galleries_test_util.cc
diff --git a/chrome/browser/media_galleries/media_galleries_test_util.cc b/chrome/browser/media_galleries/media_galleries_test_util.cc
index 198446ff2f40933b9c91fc7a3257456a230580d9..39078f80c10ca497e8d3d36fde703027ea77a5f3 100644
--- a/chrome/browser/media_galleries/media_galleries_test_util.cc
+++ b/chrome/browser/media_galleries/media_galleries_test_util.cc
@@ -6,6 +6,8 @@
#include <stddef.h>
+#include <utility>
+
#include "base/base_paths.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
@@ -52,11 +54,11 @@ scoped_refptr<extensions::Extension> AddMediaGalleriesApp(
base::ListValue* permission_detail_list = new base::ListValue;
for (size_t i = 0; i < media_galleries_permissions.size(); i++)
permission_detail_list->AppendString(media_galleries_permissions[i]);
- base::DictionaryValue* media_galleries_permission =
- new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> media_galleries_permission(
+ new base::DictionaryValue());
media_galleries_permission->Set("mediaGalleries", permission_detail_list);
base::ListValue* permission_list = new base::ListValue;
- permission_list->Append(media_galleries_permission);
+ permission_list->Append(std::move(media_galleries_permission));
manifest->Set(extensions::manifest_keys::kPermissions, permission_list);
extensions::ExtensionPrefs* extension_prefs =
« no previous file with comments | « chrome/browser/media_galleries/media_galleries_preferences.cc ('k') | chrome/browser/metrics/plugin_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698