chrome/browser/ui/webui/options/clear_browser_data_handler.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/certificate_manager_handler.cc ('k') | chrome/browser/ui/webui/options/content_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

index 61332e7ea89956c5f2a3aaee1d91526321b21196..b4b15d3b832a48a855e054908db8a10fa38ea8b9 100644

--- a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

+++ b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

@@ -6,6 +6,7 @@

#include <stddef.h>

+#include <memory>

#include <utility>

#include "base/bind.h"

@@ -215,10 +216,10 @@ void ClearBrowserDataHandler::GetLocalizedValues(

label_string = l10n_util::GetStringUTF16(IDS_CLEAR_DATA_EVERYTHING);

break;

}

- base::ListValue* option = new base::ListValue();

+ std::unique_ptr<base::ListValue> option(new base::ListValue());

option->AppendInteger(i);

option->AppendString(label_string);

- time_list->Append(option);

+ time_list->Append(std::move(option));

}

localized_strings->Set("clearBrowserDataTimeList", time_list);

localized_strings->SetBoolean("showDeleteBrowsingHistoryCheckboxes",