chrome/browser/extensions/extension_messages_apitest.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_messages_apitest.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/convert_web_app.cc ('k') | chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_messages_apitest.cc

diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc

index c42be26dda1234ec3bade244aa3800fa76ac4023..2ecbf6644bc77d2284bd71b2e5e854165ac6553a 100644

--- a/chrome/browser/extensions/extension_messages_apitest.cc

+++ b/chrome/browser/extensions/extension_messages_apitest.cc

@@ -4,6 +4,8 @@

#include <stddef.h>

#include <stdint.h>

+#include <memory>

#include <utility>

#include "base/base64.h"

@@ -65,11 +67,11 @@ class MessageSender : public content::NotificationObserver {

static std::unique_ptr<base::ListValue> BuildEventArguments(

const bool last_message,

const std::string& data) {

- base::DictionaryValue* event = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> event(new base::DictionaryValue());

event->SetBoolean("lastMessage", last_message);

event->SetString("data", data);

std::unique_ptr<base::ListValue> arguments(new base::ListValue());

- arguments->Append(event);

+ arguments->Append(std::move(event));

return arguments;

}