chrome/browser/extensions/convert_user_script.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/convert_user_script.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc ('k') | chrome/browser/extensions/convert_web_app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/convert_user_script.cc

diff --git a/chrome/browser/extensions/convert_user_script.cc b/chrome/browser/extensions/convert_user_script.cc

index 316b6e56defe97e9c1175236d0f262aa5312f32f..2d4c18b1fa489a4df04d50a072a1f31bb1d74c6f 100644

--- a/chrome/browser/extensions/convert_user_script.cc

+++ b/chrome/browser/extensions/convert_user_script.cc

@@ -6,7 +6,9 @@

#include <stddef.h>

+#include <memory>

#include <string>

+#include <utility>

#include <vector>

#include "base/base64.h"

@@ -137,7 +139,8 @@ scoped_refptr<Extension> ConvertUserScriptToExtension(

for (size_t i = 0; i < script.exclude_globs().size(); ++i)

excludes->AppendString(script.exclude_globs().at(i));

- base::DictionaryValue* content_script = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> content_script(

+ new base::DictionaryValue());

content_script->Set(keys::kMatches, matches);

content_script->Set(keys::kExcludeMatches, exclude_matches);

content_script->Set(keys::kIncludeGlobs, includes);

@@ -153,7 +156,7 @@ scoped_refptr<Extension> ConvertUserScriptToExtension(

content_script->SetString(keys::kRunAt, values::kRunAtDocumentIdle);

base::ListValue* content_scripts = new base::ListValue();

- content_scripts->Append(content_script);

+ content_scripts->Append(std::move(content_script));

root->Set(keys::kContentScripts, content_scripts);