chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/certificates_handler.cc ('k') | chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

diff --git a/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc b/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

index 9e8be216f64f3760805318fbfd8ef0333bfc48c4..29c624922d2794b8bb17cc940b79029a687384ea 100644

--- a/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

+++ b/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

@@ -6,6 +6,9 @@

#include <stddef.h>

+#include <memory>

+#include <utility>

#include "base/bind.h"

#include "base/macros.h"

#include "chrome/browser/profiles/profile.h"

@@ -117,10 +120,10 @@ void MediaDevicesSelectionHandler::UpdateDevicesMenu(

std::string default_id;

base::ListValue device_list;

for (size_t i = 0; i < devices.size(); ++i) {

- base::DictionaryValue* entry = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue());

entry->SetString("name", devices[i].name);

entry->SetString("id", devices[i].id);

- device_list.Append(entry);

+ device_list.Append(std::move(entry));

if (devices[i].id == default_device)

default_id = default_device;

}