chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/speech/extension_api/tts_extension_api.cc ('k') | chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc

diff --git a/chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc b/chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc

index 813419ec184c72826507cd045a69303979a22ca4..5622064f0736318f1a59489394d937ff69852252 100644

--- a/chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc

+++ b/chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc

@@ -8,6 +8,7 @@

#include <memory>

#include <string>

+#include <utility>

#include <vector>

#include "base/json/json_writer.h"

@@ -72,7 +73,8 @@ std::string BuildGetFamilyMembersResponse(

base::ListValue* list = new base::ListValue;

for (size_t i = 0; i < members.size(); i++) {

const FamilyInfoFetcher::FamilyMember& member = members[i];

- base::DictionaryValue* member_dict = new base::DictionaryValue;

+ std::unique_ptr<base::DictionaryValue> member_dict(

+ new base::DictionaryValue);

member_dict->SetStringWithoutPathExpansion("userId",

member.obfuscated_gaia_id);

member_dict->SetStringWithoutPathExpansion(

@@ -97,7 +99,7 @@ std::string BuildGetFamilyMembersResponse(

member_dict->SetWithoutPathExpansion("profile", profile_dict);

}

- list->Append(member_dict);

+ list->Append(std::move(member_dict));

}

dict.SetWithoutPathExpansion("members", list);

std::string result;