chrome/browser/extensions/api/autotest_private/autotest_private_api.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

diff --git a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc b/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

index abbd913c166da88e2fc6d50da1fcf38baeabac1c..e5a85eb14cfc99f2cbc1f50eeb0a10e58b6ca0f8 100644

--- a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

+++ b/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

@@ -173,7 +173,8 @@ bool AutotestPrivateGetExtensionsInfoFunction::RunSync() {

it != all.end(); ++it) {

const Extension* extension = it->get();

std::string id = extension->id();

- base::DictionaryValue* extension_value = new base::DictionaryValue;

+ std::unique_ptr<base::DictionaryValue> extension_value(

+ new base::DictionaryValue);

extension_value->SetString("id", id);

extension_value->SetString("version", extension->VersionString());

extension_value->SetString("name", extension->name());

@@ -205,7 +206,7 @@ bool AutotestPrivateGetExtensionsInfoFunction::RunSync() {

"hasPageAction",

extension_action_manager->GetPageAction(*extension) != NULL);

- extensions_values->Append(extension_value);

+ extensions_values->Append(std::move(extension_value));

}

std::unique_ptr<base::DictionaryValue> return_value(