chrome/browser/extensions/api/file_system/file_system_api.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_api.cc ('k') | chrome/browser/extensions/api/font_settings/font_settings_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/file_system/file_system_api.cc

diff --git a/chrome/browser/extensions/api/file_system/file_system_api.cc b/chrome/browser/extensions/api/file_system/file_system_api.cc

index bd9222c674b5dbaa6b0c8c53f595ca88078c1d70..e241caa364d39bde2c5349acbad8da05adcbacc4 100644

--- a/chrome/browser/extensions/api/file_system/file_system_api.cc

+++ b/chrome/browser/extensions/api/file_system/file_system_api.cc

@@ -546,7 +546,7 @@ void FileSystemEntryFunction::AddEntryToResult(const base::FilePath& path,

bool success = result->GetList("entries", &entries);

DCHECK(success);

- base::DictionaryValue* entry = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue());

entry->SetString("fileSystemId", file_entry.filesystem_id);

entry->SetString("baseName", file_entry.registered_name);

if (id_override.empty())

@@ -554,7 +554,7 @@ void FileSystemEntryFunction::AddEntryToResult(const base::FilePath& path,

else

entry->SetString("id", id_override);

entry->SetBoolean("isDirectory", is_directory_);

- entries->Append(entry);

+ entries->Append(std::move(entry));

}

void FileSystemEntryFunction::HandleWritableFileError(