chrome/browser/ui/webui/options/options_ui.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/options_ui.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/media_devices_selection_handler.cc ('k') | chrome/browser/ui/webui/options/startup_pages_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/options_ui.cc

diff --git a/chrome/browser/ui/webui/options/options_ui.cc b/chrome/browser/ui/webui/options/options_ui.cc

index 05076b72427e34edc4782157341ca763dc0b9d55..ac1f5d9e148511cbd596d8603c739eaf6a3c2f77 100644

--- a/chrome/browser/ui/webui/options/options_ui.cc

+++ b/chrome/browser/ui/webui/options/options_ui.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/ui/webui/options/options_ui.h"

#include <algorithm>

+#include <utility>

#include <vector>

#include "base/callback.h"

@@ -414,11 +415,11 @@ void OptionsUI::ProcessAutocompleteSuggestions(

type != AutocompleteMatchType::NAVSUGGEST_PERSONALIZED) {

continue;

}

- base::DictionaryValue* entry = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue());

entry->SetString("title", match.description);

entry->SetString("displayURL", match.contents);

entry->SetString("url", match.destination_url.spec());

- suggestions->Append(entry);

+ suggestions->Append(std::move(entry));

}